add auto-completion for narration #1888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagebu
reviewed
Nov 24, 2024
dtrai2
force-pushed
the
add-auto-completion-for-narration
branch
from
9429726 to
bf4a938
Compare
yagebu
force-pushed
the
add-auto-completion-for-narration
branch
from
80d3f7d to
51cda3b
Compare
yagebu
approved these changes
Jul 2, 2025
Member
yagebu
left a comment
yagebu
left a comment
There was a problem hiding this comment.
Thanks, LGTM :)
I've only modified it slightly so that attributes.narrations is a @property and used a snapshot test to have some fewer "hand-written" tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
third time's the charm
I accidentally deleted my changes again and closed the pull request #1816, luckily we have something like
git reflogwith which I could reconstruct it.Anyways this is still my attempt to add the auto-completion feature for the narration text field. It is still not perfect, but I didn't want to let the changes go to waste. Maybe it's good enough like this or someone might help out to finish it (see my last comment on #1816).
closes #1535, #1145