fix: narration isn't stored when the focus is on the narration input #2149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
val3344
added a commit
to val3344/fava
that referenced
this pull request
Dec 24, 2025
…n input (beancount#2149)" This reverts commit fd25213.
yagebu
pushed a commit
that referenced
this pull request
Dec 30, 2025
* Revert "fix: narration isn't stored when the focus is on the narration input (#2149)" This reverts commit fd25213. This commit caused a regression where spaces could not be entered in the narration input field. Reverting to fix the space input issue and will implement a proper fix. * fix: update narration tags/links on Enter key press Add onEnter handler to narration input in Transaction.svelte to ensure narration tags and links are processed when the user presses Enter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue:
If you type text in the narration text field in the Add Entry dialog, then press Enter within the narration text field, the narration text is not saved.