Optimize photoset downloads with bulk metadata fetch #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use extras parameter in getPhotos() to fetch URLs and metadata in bulk - Add helper functions to extract URLs from extras and download directly - Skip per-photo API calls when pre-fetched data is available - Reduces API calls from 3-4 per photo to 0 additional calls This significantly speeds up large photoset downloads and reduces the likelihood of hitting API rate limits. Closes #64 Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add tests for _get_url_from_extras() function - Add tests for _get_extension_from_url() function - Add tests for _download_file() function - Add test for download using prefetched URL flow Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
extrasparameter ingetPhotos()to fetch URLs and metadata in bulkDetails
When downloading a photoset, the Flickr API now fetches URL data for multiple sizes (
url_o,url_l,url_c, etc.) along withoriginal_formatanddate_takenin the initial paginated call. This eliminates the need for:photo._getOutputFilename()- extension determined from URLphoto._getLargestSizeLabel()- URL availability indicates size availabilityphoto.save()API overhead - direct HTTP download using pre-fetched URLTest plan
uv run pytest -v-vflagCloses #64
🤖 Generated with Claude Code