Add local-first resume checking for faster download resumption #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fast local-first checking to skip already-downloaded photos without making any API calls: - Add _check_file_exists_by_id() to check for existing files by photo ID - Supports id, id_and_title, and title_and_id naming patterns - Check runs before any API calls are made This significantly speeds up resuming large downloads (17k+ photos) where most files already exist locally. Closes #63 Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add tests for _check_file_exists_by_id() function - Add test for local-first skip by ID pattern in do_download_photo Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_check_file_exists_by_id()to check for existing files by photo ID patternid,id_and_title, andtitle_and_idnaming patternsProblem
When resuming a large download (e.g., 17k+ photos), the current implementation makes API calls for each photo to determine if it needs to be downloaded. This can fail due to rate limits, preventing resumption.
Solution
Before making any API calls, check the local filesystem for files matching the photo ID pattern. This enables instant skipping of already-downloaded photos.
Test plan
uv run pytest -vCloses #63
🤖 Generated with Claude Code