Skip to content

Iteration 3 - When Searching w/ a Filter, UI should Indicate Hidden Results#412

Open
kienthuynh wants to merge 1 commit intobeautyjoy:mainfrom
cs169:feature/hidden-search-results
Open

Iteration 3 - When Searching w/ a Filter, UI should Indicate Hidden Results#412
kienthuynh wants to merge 1 commit intobeautyjoy:mainfrom
cs169:feature/hidden-search-results

Conversation

@kienthuynh
Copy link
Copy Markdown
Contributor

@kienthuynh kienthuynh commented Apr 22, 2026

Summary

  • When searching the teachers table with some status checkboxes unchecked, a notice now appears directly below the "Showing X to Y of Z entries" line indicating how many matching records are hidden by the current filter (e.g. 1 result(s) in Denied, 2 result(s) in Not Reviewed — hidden by current filter)
  • image

Implementation Notes

  • app/javascript/packs/datatables.js: Uses DataTables' public row().cache('search') API to count against pre-computed in-memory search data then injects notice text below the main results text
  • features/step_definitions/table_steps.rb: Adds a new step definition that only populates the search for the teachers table, since the teachers index has both the teachers and admins tables

Testing

@cycomachead @armandofox @mdawn65

@hagenhaeussler
Copy link
Copy Markdown

yep, looks all good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants