Iteration 3 - When Searching w/ a Filter, UI should Indicate Hidden Results#412
Open
kienthuynh wants to merge 1 commit intobeautyjoy:mainfrom
Open
Iteration 3 - When Searching w/ a Filter, UI should Indicate Hidden Results#412kienthuynh wants to merge 1 commit intobeautyjoy:mainfrom
kienthuynh wants to merge 1 commit intobeautyjoy:mainfrom
Conversation
|
yep, looks all good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1 result(s) in Denied, 2 result(s) in Not Reviewed — hidden by current filter)Implementation Notes
app/javascript/packs/datatables.js:Uses DataTables' publicrow().cache('search')API to count against pre-computed in-memory search data then injects notice text below the main results textfeatures/step_definitions/table_steps.rb:Adds a new step definition that only populates the search for the teachers table, since the teachers index has both the teachers and admins tablesTesting
@cycomachead @armandofox @mdawn65