Add sort indicator arrows and pointer cursor to DataTable headers#424
Open
ronikriger wants to merge 1 commit into
Open
Add sort indicator arrows and pointer cursor to DataTable headers#424ronikriger wants to merge 1 commit into
ronikriger wants to merge 1 commit into
Conversation
Custom CSS-only approach using ::after pseudo-elements with Unicode triangles. White on dark headers, half-opacity unsorted indicator, full-opacity for active sort direction. No arrow on non-orderable columns (sorting_disabled). Applies globally to all DataTables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom CSS-only approach using ::after pseudo-elements with Unicode triangles. White on dark headers, half-opacity unsorted indicator, full-opacity for active sort direction. No arrow on non-orderable columns (sorting_disabled). Applies globally to all DataTables.
What this PR does:
_datatable_sorting.scsswith custom::afterpseudo-element arrows (▲/▼) for.sorting,.sorting_asc, and.sorting_descheader classes.cursor: pointer; non-sortable headers (.sorting_disabled) show no arrow andcursor: default..thead-darkbackgrounds for visibility.application.scss.Who authored this PR?
@ronikriger
How should this PR be tested?
/teachers,/schools)bundle exec cucumber features/datatable_sort_indicators.feature@cycomachead @armandofox @mdawn65