Iteration 4 - Fix personal email deletion confirm and last-email guard#429
Open
kienthuynh wants to merge 1 commit intobeautyjoy:mainfrom
Open
Iteration 4 - Fix personal email deletion confirm and last-email guard#429kienthuynh wants to merge 1 commit intobeautyjoy:mainfrom
kienthuynh wants to merge 1 commit intobeautyjoy:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a copy of cs169#108 on the local repo. @NishK05's work.
Fixes Bugs Caught in the discussion related to deleting emails and also not allowing teachers or admins to leave teachers with no emails.
Issue 1: On the confirm delete page, even if you clicked cancel, the email would be deleted
-fixes the logic for delete
Issue 2: You could delete a teacher's only email and leave them with no contact info
-added a client and server-side check to ensure 1 email is always stored.
@cycomachead @armandofox @mdawn65