Skip to content

Feat/py03 build#1

Closed
d-perl wants to merge 4 commits intomainfrom
feat/py03_build
Closed

Feat/py03 build#1
d-perl wants to merge 4 commits intomainfrom
feat/py03_build

Conversation

@d-perl
Copy link
Copy Markdown
Collaborator

@d-perl d-perl commented Aug 8, 2025

Adds a python module from which the ingestor can be run

install maturin and build the python wheel and module with maturin develop in a venv

@codecov-commenter
Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@d-perl d-perl marked this pull request as ready for review August 18, 2025 08:30
@unkcpz
Copy link
Copy Markdown
Contributor

unkcpz commented Aug 20, 2025

The folder hierarchy restructured in this PR seems you might want it only be a python library? Why not keep the original layout and adding a python folder and provide python lib as an extra thing? Since you provide the rust binary, if I am a user I'd prefer just to download the binary and run instead of pip install.

@d-perl
Copy link
Copy Markdown
Collaborator Author

d-perl commented Aug 21, 2025

hey @unkcpz thanks for the suggestion, I might do that. Originally this was because we need a deployment solution which works with what our linux team has set up for the beamline machines. Our ops guy asked me to make it so he could install it from PyPI, also it would help us with the dependency management from the main package in case the message format changes. But in the end we will probably package the binary as an RPM from the PSI Gitea instead, so I might change the layout again to reflect that.

@d-perl d-perl closed this Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants