Conversation
wakonig
force-pushed
the
feature/motor_export
branch
from
606fdf0 to
228fb97
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the device configuration templates to reference ophyd_devices-exported classes (instead of ophyd.*) so configs can consistently point at this package’s public API, and expands the motor template variants.
Changes:
- Switch
OPHYD_DEVICE_TEMPLATES[*][*]["deviceClass"]strings fromophyd.*toophyd_devices.*. - Add additional motor template variants (
EpicsMotorEC,EpicsUserMotorVME) under theEpicsMotorgroup. - Re-export
EpicsSignal,EpicsSignalRO, andEpicsSignalWithRBVfromophyd_devices/__init__.pyto supportophyd_devices.*class-path resolution.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
ophyd_devices/interfaces/device_config_templates/ophyd_templates.py |
Updates template deviceClass strings and adds motor variants in the template map. |
ophyd_devices/__init__.py |
Re-exports ophyd EPICS signal classes at the package root to match new template class paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cappel89
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.