Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a utility to actively poll ophyd.Signal instances (or arbitrary callables) on a background thread, intended to support asynchronous synchronization for hardware sources that don’t produce passive updates.
Changes:
- Introduces
SignalMonitoring, a thread-based polling manager withstart/stop/shutdown. - Supports registering either
ophyd.Signalinstances (polled viaget()) or custom callables (polled via invocation). - Adds a configurable polling interval.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cappel89
force-pushed
the
feat/add-signal-monitoring-tool
branch
from
c648f24 to
6f5951b
Compare
cappel89
force-pushed
the
feat/add-signal-monitoring-tool
branch
from
6f5951b to
66db1ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a tool that allows to register signals or small callable scripts to poll from HW that is integrated in form of an ophyd.Signal. This allows us to implement synchronization logic asynchronously if combined with Compare/TransitionStatus objects for HW that usually does not support passive updates (i.e. EPICS HW without proper auto_monitor support, SocketSignals or HTTP signals). This type of logic is however regularly needed for complete, trigger etc.
TODO
Comment
I think it could be merged before tests with HW. The unit test indicates that it works well! If someone persists on HW test before merging, I can look into it.