lastgenre: Apply canonicalization to genres of items with no Last.fm results#6383
lastgenre: Apply canonicalization to genres of items with no Last.fm results#6383Bergbok wants to merge 4 commits intobeetbox:masterfrom
Conversation
1061f9d to
c08f473
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6383 +/- ##
==========================================
+ Coverage 68.96% 68.97% +0.01%
==========================================
Files 140 140
Lines 18685 18683 -2
Branches 3056 3055 -1
==========================================
+ Hits 12886 12887 +1
+ Misses 5155 5154 -1
+ Partials 644 642 -2
🚀 New features to boost your workflow:
|
c08f473 to
67f7658
Compare
A blacklist feature is in the pipeline but it will take a while until it's ready. 2 other lastgenre PR's need to go first. You could test from the branch but I suggest with a test library setup only for now: #5744 |
|
Please let's wait with this one. There is other things to be done and I'm not entirely sure how this could/should be implemented. Sorry for the inconvenience and many thanks for the efforts! Speak soon! |
Hi again, I was working on getting the blacklist feature ready for a final review this weekeend. If you want you can test it from the It would help if you could report if it suits your use-cases. Thanks and have a great week! |
I've been configuring my canonicalization tree to remove tags I don't like, essentially using it like a blacklist, and noticed some tags not being removed after re-running the lastgenre command.
The reason for this is that when
keep_existingis enabled and no Last.fm results are found, the existing genres are returned as-is without being processed through_resolve_genres(). This means existing genres that should be filtered by the canonicalization tree are kept unchanged.As an example, if I had this in my canonicalization tree:
and then ran lastgenre on a track with 'some tag', but which had no data on Last.fm, it wouldn't get removed from the track. This PR fixes that.