Use va_name config for all artist fields on VA releases#6438
Merged
snejus merged 1 commit intobeetbox:masterfrom Mar 13, 2026
Merged
Use va_name config for all artist fields on VA releases#6438snejus merged 1 commit intobeetbox:masterfrom
snejus merged 1 commit intobeetbox:masterfrom
Conversation
When importing compilations, albumartist_sort, albumartists_sort, albumartist_credit, albumartists_credit, and albumartists were hardcoded to "Various Artists" instead of using the user-configured va_name setting. This also fixes the same issue in the beatport plugin. Fixes beetbox#6316
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6438 +/- ##
=======================================
Coverage 69.55% 69.55%
=======================================
Files 141 141
Lines 18493 18494 +1
Branches 3025 3025
=======================================
+ Hits 12862 12863 +1
Misses 4995 4995
Partials 636 636
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6316
When importing compilations/various artists albums, several fields used the
hardcoded string "Various Artists" instead of the user-configured
va_namesetting:
In the musicbrainz plugin, only
info.artistwas overridden withva_namewhen a release was identified as VA. The
artist_sort,artists_sort,artist_credit,artists_credit, andartistsfields were left with the rawMusicBrainz value ("Various Artists"), which then propagated to
albumartist_sort,albumartists_sort,albumartist_credit,albumartists_credit, andalbumartistson items.In the beatport plugin, the VA artist name was hardcoded to
"Various Artists" instead of reading from config.
Changes
beetsplug/musicbrainz.py: Wheninfo.vais true, override all artist-relatedfields (
artist_sort,artists,artists_sort,artist_credit,artists_credit) withva_name, not justartist.beetsplug/beatport.py: Replace hardcoded "Various Artists" withconfig["va_name"].as_str().docs/changelog.rst: Add changelog entries for both fixes.Test plan
va_namesetting (e.g.,va_name: "Artistes divers") and verify thatalbumartist_sort,albumartists_sort,albumartist_credit,albumartists_credit, andalbumartistsall use the configured value.beet mbsyncon an existing VA album after changingva_nameand verifythe sort/credit fields update correctly.
va_name, the default "Various Artists" is stillused everywhere (no behavior change for default config).