Add support for client-requested NTPv4 server address/port #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SessionOptions RequestedNTPServerAddress and RequestedNTPServerPort have been added. Clients may use them to request a specific NTP server address and port when contacting the NTS key exchange server.
beevik
force-pushed
the
client-request
branch
from
0a98cd7 to
8fa3818
Compare
|
Some preliminary testing seems to suggest it works - but I'm hitting the limits of NTS as well as my knowledge about it here, so I would have look closer to confirm. Thanks for this quick response - much appreciated! |
Owner
Author
|
I think a lot of this will depend on how the NTS server you're using is implemented. According to the RFC, the server is free to ignore requests for a specific NTP server address or port. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SessionOptions RequestedNTPServerAddress and RequestedNTPServerPort have been added. Clients may use them to request a specific NTP server address and port when contacting the NTS key exchange server.