Allow for runpy returning non-integer results. #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsmith
reviewed
Jan 21, 2025
Comment on lines
249
to
250
| // Convert exit code to a string. This is required by runpy._error | ||
| ret = -11; |
Member
There was a problem hiding this comment.
Incorrect comment: we don't actually convert the string on this platform, we just call PyErr_Print below.
mhsmith
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44
Implements largely the same fix as beeware/briefcase-macOS-Xcode-template#65; however. the workflow around printing the error is slightly different because the iOS stub app runs app's main loop, where as in macOS the Python code starts the loop.
PR Checklist: