-
-
Notifications
You must be signed in to change notification settings - Fork 7
Update web template and enable insert-based injection (Phase 4) #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8cf80af
Update index.html with insert markers
kavi2du 0678a14
Add insert marker for toolkit styles in briefcase.css
kavi2du ecf33d2
Update the warning message block in briefcase.css
kavi2du 7229c9c
Minor fix
kavi2du c53768c
Update toolkit insert comment
caydnn 1d565b8
pyscript version markers
caydnn f4c4096
Minor fix for CSS banner style inconsistency
kavi2du d0c2d73
Change pyscript version
caydnn bf80710
Moved "toolkit styles" below comment block
caydnn a9277f7
Update toolkit head and add script insert points to index.html
kavi2du 765dcf7
Update toolkit CSS marker comment and remove outdated block in briefc…
kavi2du 143d2af
Correction to match insertion marker format
caydnn d1440a2
replace "end" with "body-end" in marker
caydnn 22a8e8b
Add body-start marker and change Pyscript marker to python marker
caydnn 26b8b82
change insert tags to lower case
caydnn b7adfdd
remove pyscript body script and add body-python tag
caydnn cd84b61
fix typo
caydnn 2445fc9
Minor renaming in head comment
freakboy3742 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,52 +14,34 @@ | |
| <meta property="og:type" content="website"> | ||
| <meta property="og:image" content="/static/social.png"> | ||
|
|
||
| <!-- PyScript --> | ||
| <!-- Python Implementation --> | ||
|
|
||
| <script type="module"> | ||
| // Hide the splash screen when the page is ready. | ||
| import { hooks } from "https://pyscript.net/releases/2024.11.1/core.js"; | ||
| hooks.main.onReady.add(() => { | ||
| document.getElementById("briefcase-splash").classList.add("hidden"); | ||
| }); | ||
| </script> | ||
| <!--@@ head-python:start @@--> | ||
| <!--@@ head-python:end @@--> | ||
|
|
||
| <link rel="stylesheet" href="https://pyscript.net/releases/2024.11.1/core.css"> | ||
| <script type="module" src="https://pyscript.net/releases/2024.11.1/core.js"></script> | ||
| <!-- Toolkit Head Insert (any valid <head> content)--> | ||
|
|
||
| <!-- App Style --> | ||
| <!--@@ head:start @@--> | ||
| <!--@@ head:end @@--> | ||
|
|
||
| {% if cookiecutter.style_framework == "Bootstrap v4.6" %} | ||
| <link rel="stylesheet" | ||
| href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css" | ||
| integrity="sha384-xOolHFLEh07PJGoPkLv1IbcEPTNtaed2xpHsD9ESMhqIYd0nLMwNLD69Npy4HI+N" | ||
| crossorigin="anonymous"> | ||
| {% elif cookiecutter.style_framework == "Shoelace v2.3" %} | ||
| <link rel="stylesheet" | ||
| href="https://cdn.jsdelivr.net/npm/@shoelace-style/[email protected]/dist/themes/light.css" /> | ||
| <script type="module" | ||
| src="https://cdn.jsdelivr.net/npm/@shoelace-style/[email protected]/dist/shoelace.js"></script> | ||
| {% endif %} | ||
| <link rel="stylesheet" href="/static/css/briefcase.css"> | ||
| </head> | ||
| <body id="app-placeholder"> | ||
| <div id="briefcase-splash"> | ||
| <img src="static/logo-32.png" alt="Splash screen logo"> | ||
| <p>Loading...</p> | ||
| </div> | ||
| {% if cookiecutter.style_framework == "Bootstrap v4.6" %} | ||
| <script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/jquery.slim.min.js" | ||
| integrity="sha384-DfXdz2htPH0lsSSs5nCTpuj/zy4C+OGpamoFVy38MVBnE+IbbVYUew+OrCXaRkfj" | ||
| crossorigin="anonymous"></script> | ||
| <script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.bundle.min.js" | ||
| integrity="sha384-Fy6S3B9q64WdZWQUiU+q4/2Lc9npb8tCaSX9FK7E8HnRr0Jz8D6OP9dO5Vg3Q9ct" | ||
| crossorigin="anonymous"></script> | ||
| {% endif %} | ||
| <script type="py" async="false" config="pyscript.toml"> | ||
| import runpy | ||
| result = runpy.run_module( | ||
| "{{ cookiecutter.module_name }}", run_name="__main__", alter_sys=True | ||
| ) | ||
| </script> | ||
|
|
||
| <!--@@ body-start:start @@--> | ||
| <!--@@ body-start:end @@--> | ||
|
|
||
| <!--@@ body-python:start @@--> | ||
| <!--@@ body-python:end @@--> | ||
|
|
||
| <!-- Toolkit Body Insert (any valid <script> tags)--> | ||
|
|
||
| <!--@@ body-end:start @@--> | ||
| <!--@@ body-end:end @@--> | ||
|
|
||
| </body> | ||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.