Restore Pyside6 tests, enable long filename support#62
Merged
Conversation
Merged
4 tasks
Member
Author
|
Evidently just upgrading WiX isn't enough... |
Member
Author
|
Looks like you also have to use a |
mhsmith
approved these changes
Jul 11, 2025
Member
|
Even Microsoft documentation about this syntax is often incomplete or incorrect. This is the best explanation I could find. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beeware/briefcase#2355 upgrades the WiX version to WiX 5, which should no longer have the the path length restriction - so we can restore pyside6 tests to the Windows tests. However, we do need to make a small change to the template to trigger long file name support.
Fixes beeware/briefcase#948.
PR Checklist: