Update wxs for WiX 5

[rmartin16]

Created with wix convert app.wxs

[Remainder added by @mhsmith]

Related PRs:

• Update to WiX 5 briefcase#2355
• Update wxs for WiX 5 briefcase-windows-VisualStudio-template#60
  • The "app" PR (the one you're currently viewing) contains the commit history of the files that are shared by both templates, so let's keep any discussion of those files here.

The most significant changes are connected to scope selection (per-machine vs per-user). This interacts with almost every feature of the installer, and testing revealed several pre-existing bugs, especially when the installer starts up defaulting to per-user scope, and then the user selects per-machine. The solutions I came up with are somewhat awkward, but they're explained in comments as clearly as I can.

briefcase-repo: https://github.com/mhsmith/briefcase.git
briefcase-ref: wix4

PR Checklist:

• All new features have been tested
• All new features have been documented
• I have read the CONTRIBUTING.md file
• I will abide by the code of conduct

[mhsmith]

@rmartin16: Do you remember how did you do this conversion? I guess the conversion tool wouldn't accept an XML file with Jinja markup, so did you convert each section separately and then stitch them together?

[rmartin16]

hmm....I can't say I remember specifically. However, I certainly wouldn't have been able to use the template version of the XML as you call out. So, I would have expected that I created a project and ran the tool over the generated XML from the template; from there, I would have created a diff of the input/output XML files and manually applied those differences back to the template.

[mhsmith]

The Upgrade element is no longer required because WiX now handles this by default.

[mhsmith]

The RemoveExistingProducts element is no longer required because WiX now handles this by default.

However, we did need to alter the sequence of FindRelatedProducts below in order for it to react to the configurable install scope. This was a pre-existing bug.

[freakboy3742]

These changes all make sense, and you can't argue with success - they all work as advertised (as best as I can make out). Nice work on finding those edge case scoping issues as well.