changed error text in build_app to hint user for virus scanner problems#2400
Merged
Conversation
…irus scanner problems with rcedit
freakboy3742
approved these changes
Jul 19, 2025
freakboy3742
left a comment
freakboy3742
left a comment
Member
There was a problem hiding this comment.
Looks good - a couple of suggestions inline!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I adapted the text output on the BriefcaseCommandError in the build_app function in the windows platforms app.py to hint the user on disabling the virus scanner or adding rcedit to the whitelist. The error originates from the rcedit subprocess and to prevent hunting process-specific errors the error message was added here.
The issue was that sometimes a very generic error popped up when the Windows build failed because of use of rcedit.exe being blocked by virus scanners.
This PR related to issue #1530
PR Checklist:
The tests failed on MacOS tests, which shouldn't have run on my platform. This may be a my-environment-problem or something else. To trigger the tests on PR i created the PR after consulting Russel.
Not Applicable