Skip to content

Conversation

kattni
Copy link
Contributor

@kattni kattni commented Oct 15, 2025

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@kattni kattni marked this pull request as draft October 15, 2025 06:23
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API docs looks great. A couple of minor cosmetic issues flagged in the review notes; the only one that might need a deeper audit is the use of () on :meth: replacements.

:class:`float` based on the type of its contents
Other objects are returned unmodified as an :class:`ObjCInstance`.
* [`objc_id`][rubicon.objc.runtime.objc_id]: Wrapped in an
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some odd indentation and bolding here (and in ns_for_py - I think it's the newline being interpreted as a new bullet level?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I'm seeing what you're seeing here. Either in the PR build, or my local build. Can you post a screenshot, please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm - looks like it's not happening any more... I wonder if it might be a cascading side effect of one of the previous markup errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants