-
-
Notifications
You must be signed in to change notification settings - Fork 59
WIP: Move to MkDocs from Sphinx. #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API docs looks great. A couple of minor cosmetic issues flagged in the review notes; the only one that might need a deeper audit is the use of ()
on :meth: replacements.
:class:`float` based on the type of its contents | ||
Other objects are returned unmodified as an :class:`ObjCInstance`. | ||
* [`objc_id`][rubicon.objc.runtime.objc_id]: Wrapped in an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some odd indentation and bolding here (and in ns_for_py
- I think it's the newline being interpreted as a new bullet level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I'm seeing what you're seeing here. Either in the PR build, or my local build. Can you post a screenshot, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm - looks like it's not happening any more... I wonder if it might be a cascading side effect of one of the previous markup errors.
Co-authored-by: Russell Keith-Magee <[email protected]>
PR Checklist: