Support CSS font size keywords #3242

peschwartz · 2025-03-07T10:52:34Z

Added backend support for CSS font-size keywords to Android, Cocoa, iOS, GTK, and Windows and updated the core and travertino testing suites. Includes updated documentation.

Fixes #1814

PR Checklist:

All new features have been tested
All new features have been documented
I have read the CONTRIBUTING.md file
I will abide by the code of conduct

Add: CSS keyword constants to Travertino and update core style component #17 Update: testbed to handle CSS keywords and improve coverage #24 Add: CSS font size keywords and tests for iOS #5 #10 (#18) Add: windows CSS keyword support and tests #6 #11 (#22) Add: Cocoa CSS keywords support and tests #3 #8 (#23) Add: Gtk css keywords support and tests #4 #9 (#27) Fix: remove xxxl keywords #29 Docs: add css keywords to style reference (#33) Add: Android support for CSS font keywords and tests #2 #7 (#28) ---------- Co-authored-by: Phoebe Schwartz <[email protected]> Co-authored-by: KlaraLindemalm <[email protected]> Co-authored-by: Jacmol <[email protected]> Co-authored-by: carltestar <[email protected]>

fix relative size tests to include parent size if one exists

mhsmith

Thanks, this looks very thorough.

travertino/src/travertino/constants.py

docs/reference/style/pack.rst

fix: remove all relative_font_size instances and update documentation --------- Co-authored-by: phoebe <[email protected]>

peschwartz · 2025-03-18T20:29:02Z

Hello! We've made the changes to remove the xxxl size and the relative sizes. It passes all of the CI checks but for some reason, it is not passing the docs build. Any ideas as to why?

freakboy3742 · 2025-03-18T21:54:44Z

Hello! We've made the changes to remove the xxxl size and the relative sizes. It passes all of the CI checks but for some reason, it is not passing the docs build. Any ideas as to why?

It looks like it might be related to RTD's recent switchover to their new management UI. Your original docs builds seems to have fallen into a crack somewhere; I've manually restarted the build, and it seems to have worked. Apologies for the confusion!

travertino/tests/test_fonts.py

docs/reference/style/pack.rst

core/src/toga/fonts.py

cocoa/src/toga_cocoa/fonts.py

travertino/src/travertino/constants.py

Updated code from review.

peschwartz · 2025-04-07T18:17:48Z

@mhsmith I've implemented the changes you suggested! Let me know if there is more we can do for this PR.

freakboy3742 · 2025-04-10T10:33:57Z

@peschwartz Thanks for the update - @mhsmith and I are both travelling for work at the moment, so we're a little busy; we'll take a look as soon as we get a chance.

mhsmith · 2025-04-14T20:12:50Z

winforms/src/toga_winforms/fonts.py

+                font_size = DEFAULT_FONT.Size
+                font_size *= FONT_SIZE_SCALE[self.interface.size]


Suggested change

font_size = DEFAULT_FONT.Size

font_size *= FONT_SIZE_SCALE[self.interface.size]

font_size = DEFAULT_FONT.Size * FONT_SIZE_SCALE[self.interface.size]

mhsmith · 2025-04-14T20:13:20Z

cocoa/src/toga_cocoa/fonts.py

+                base_size = NSFont.systemFontSize
+                font_size = base_size * FONT_SIZE_SCALE[self.interface.size]


Suggested change

base_size = NSFont.systemFontSize

font_size = base_size * FONT_SIZE_SCALE[self.interface.size]

font_size = NSFont.systemFontSize * FONT_SIZE_SCALE[self.interface.size]

mhsmith · 2025-04-14T20:14:15Z

android/src/toga_android/fonts.py

+            default = base_size * FONT_SIZE_SCALE[self.interface.size]
+            return default


Suggested change

default = base_size * FONT_SIZE_SCALE[self.interface.size]

return default

return base_size * FONT_SIZE_SCALE[self.interface.size]

mhsmith · 2025-04-14T20:24:40Z

I'm not able to apply these changes because you didn't enable the "allow edits by maintainers" option. Please do that in future PRs.

Meanwhile, you don't need to do anything; I'll merge this branch by creating a separate PR.

mhsmith

OK, actually there are a few more issues, so I'll leave you to deal with them. Please enable the "allow edits by maintainers" option on this PR anyway – it's at the bottom of the right hand column.

And one more workflow point – please don't click the "resolve" button on review comments – leave that to the person who posted it. This will make it easier to keep track of what's left to be reviewed. (If you accept a suggested change, then it will resolve automatically – this is fine.)

Thanks for your updates, and sorry this is taking so long, but I think we're almost finished now.

mhsmith · 2025-04-14T20:51:55Z

changes/1814.misc.rst

@@ -0,0 +1 @@
+Added support for absolute CSS font size keywords in Android, Cocoa, GTK, iOS, and Windows.


misc change notes are hidden in the release notes. This is a publicly-visible feature, so the file should be renamed to 1814.feature.rst.

mhsmith · 2025-04-14T20:58:56Z

android/src/toga_android/fonts.py

@@ -96,6 +99,7 @@ def typeface(self, *, default=Typeface.DEFAULT):
    def size(self, *, default=None):
        """Return the font size in physical pixels."""
        context = MainActivity.singletonThis
+        base_size = 14


This size will need to be scaled in a similar way to the TypedValue.applyDimension code below. Otherwise, the text will be too small on high DPI devices (which is virtually all of them). For example, if I edit examples/font_size to use the font size keywords:

As mentioned at #1814 (comment), on Android, as far as I know, "medium" should be the same as the default for every widget except the TextInput, where the default should be larger.

Please make a similar visual check on as many other platforms as you can, and let me know which ones you've checked. Windows in high DPI mode is the most likely one to have a problem.

mhsmith · 2025-04-14T21:12:59Z

When testing on Android, I got this error:

E/AndroidRuntime: Caused by: com.chaquo.python.PyException: ModuleNotFoundError: No module named 'travertino.properties.shorthand'; 'travertino.properties' is not a package
E/AndroidRuntime:   at <python>.toga.style.pack.<module>(pack.py:40)
E/AndroidRuntime:   at <python>.toga.style.<module>(__init__.py:2)
E/AndroidRuntime:   at <python>.font_size.app.<module>(app.py:2)

And sure enough, travertino/properties/__init__.py does not exist. This is an oversight, and I'm not sure why it hasn't caused problems before, but you might as well fix it in this PR if you encounter it.

freakboy3742 · 2025-04-14T23:46:08Z

And sure enough, travertino/properties/__init__.py does not exist. This is an oversight, and I'm not sure why it hasn't caused problems before, but you might as well fix it in this PR if you encounter it.

That is... shocking... how has that not caused problems? I can only presume it's because all the existing usage is from .properties.foo import ...?

mhsmith · 2025-04-15T06:58:30Z

Maybe it's been treated as an implicit namespace package, in which case Chaquopy's custom importer may be the reason why it fails on that platform. Still not sure why it isn't breaking the testbed as well, but it's not worth looking into any further.

peschwartz · 2025-04-15T08:53:32Z

Hey @mhsmith,

We've looked at this: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork and we aren't seeing this option to allow you maintainer access. How do you think we should proceed? I can give you direct access to our repository if that works.

mhsmith · 2025-04-15T09:57:09Z

It should be at the bottom of the right hand column, as shown in the screenshot on that page. If you can't see it, never mind, I can continue suggesting the changes to you, as we have been doing so far.

sasoder and others added 2 commits March 7, 2025 10:46

Fix: GTK testbed font size tests #37 (#40)

5935112

fix relative size tests to include parent size if one exists

mhsmith reviewed Mar 10, 2025

View reviewed changes

travertino/src/travertino/constants.py Outdated Show resolved Hide resolved

travertino/src/travertino/constants.py Show resolved Hide resolved

docs/reference/style/pack.rst Outdated Show resolved Hide resolved

sasoder added 2 commits March 11, 2025 10:35

fix: correct absolute sizes, add xxl beeware#3242

849e245

docs: re-added xxl css keyword

35d8379

mhsmith mentioned this pull request Mar 11, 2025

Support CSS font size keywords #1814

Open

fix: remove all relative_font_size instances (#41)

e29909d

fix: remove all relative_font_size instances and update documentation --------- Co-authored-by: phoebe <[email protected]>

peschwartz requested a review from mhsmith March 20, 2025 12:46

mhsmith reviewed Mar 24, 2025

View reviewed changes

New changes for fix 1814 (#42)

f5bdde2

Updated code from review.

mhsmith reviewed Apr 14, 2025

View reviewed changes

johnzhou721 mentioned this pull request Jun 2, 2025

Add a missing __init__.py to Travertino. #3509

Merged

4 tasks

		font_size = DEFAULT_FONT.Size
		font_size *= FONT_SIZE_SCALE[self.interface.size]

	font_size = DEFAULT_FONT.Size
	font_size *= FONT_SIZE_SCALE[self.interface.size]
	font_size = DEFAULT_FONT.Size * FONT_SIZE_SCALE[self.interface.size]

		base_size = NSFont.systemFontSize
		font_size = base_size * FONT_SIZE_SCALE[self.interface.size]

	base_size = NSFont.systemFontSize
	font_size = base_size * FONT_SIZE_SCALE[self.interface.size]
	font_size = NSFont.systemFontSize * FONT_SIZE_SCALE[self.interface.size]

		default = base_size * FONT_SIZE_SCALE[self.interface.size]
		return default

	default = base_size * FONT_SIZE_SCALE[self.interface.size]
	return default
	return base_size * FONT_SIZE_SCALE[self.interface.size]

		@@ -0,0 +1 @@
		Added support for absolute CSS font size keywords in Android, Cocoa, GTK, iOS, and Windows.

Uh oh!

Support CSS font size keywords #3242

Are you sure you want to change the base?

Support CSS font size keywords #3242

Uh oh!

Conversation

peschwartz commented Mar 7, 2025 • edited by mhsmith Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist:

Uh oh!

mhsmith left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

peschwartz commented Mar 18, 2025

Uh oh!

freakboy3742 commented Mar 18, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

peschwartz commented Apr 7, 2025

Uh oh!

freakboy3742 commented Apr 10, 2025

Uh oh!

mhsmith Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

mhsmith Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

mhsmith Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

mhsmith commented Apr 14, 2025

Uh oh!

mhsmith left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mhsmith Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

mhsmith Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mhsmith commented Apr 14, 2025

Uh oh!

freakboy3742 commented Apr 14, 2025

Uh oh!

mhsmith commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peschwartz commented Apr 15, 2025

Uh oh!

mhsmith commented Apr 15, 2025

Uh oh!

Uh oh!

peschwartz commented Mar 7, 2025 •

edited by mhsmith

Loading

mhsmith left a comment •

edited

Loading

mhsmith Apr 14, 2025 •

edited

Loading

mhsmith commented Apr 15, 2025 •

edited

Loading