Skip to content

Correct textual app execution to prevent stray log messages #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2025

Conversation

freakboy3742
Copy link
Member

If an app is run with Textual 3.0, it generates log messages on output due to Textualize/textual#5091.

This was discovered in the context of #3299. The existing version pin was open ended, and allowed for major version changes to be required in by Toga codebase without testing.

This PR bumps the minimum Textual version to 3.0, and imposes a 4.0 upper bound to avoid similar problems emerging.

It also changes the way that the Textual app is started (effectively reproducing textual.App.run()) so that the log messages on exit are captured.

Fixes #3343.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@mhsmith mhsmith merged commit 08f644e into beeware:main Apr 20, 2025
15 of 16 checks passed
@freakboy3742 freakboy3742 deleted the textual-update branch April 21, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Textual backend raising log messages on app exit
2 participants