Correct textual app execution to prevent stray log messages #3344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mhsmith
approved these changes
Apr 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an app is run with Textual 3.0, it generates log messages on output due to Textualize/textual#5091.
This was discovered in the context of #3299. The existing version pin was open ended, and allowed for major version changes to be required in by Toga codebase without testing.
This PR bumps the minimum Textual version to 3.0, and imposes a 4.0 upper bound to avoid similar problems emerging.
It also changes the way that the Textual app is started (effectively reproducing
textual.App.run()) so that the log messages on exit are captured.Fixes #3343.
PR Checklist: