Ensure Window always has a content widget #3478
Conversation
| # Otherwise, set content to an empty Box widget | ||
| self.content = content if content else toga.Box() |
There was a problem hiding this comment.
This has resulted in a few branch coverage failures. They could be fixed by removing the if check at each branch and assuming that content is never None.
If we're committing to that invariant, then we should also update the content setter to interpret None in the same way as the constructor does. However, we're not sure whether this invariant is actually a good idea, as it prevents content=None from being round-tripped.
The presence of a default Box in the app's main window has obviously also complicated many of the tests, even if they didn't involve the main window directly.
Let's leave this PR open to discuss this question, and consider alternative approaches to the original issue in #2818.
There was a problem hiding this comment.
Alternative approach in #3479, which is now merged.
|
Alternative approach in #3479 is now merged. |
Resolves #2818, which details a bug in which the app crashes if there is no window content. This PR updates the code so that a Window is now guaranteed to have a content widget.
Prior to this change, an error would be generated when running
TOGA_BACKEND=toga_textual python -c 'import toga; toga.App(formal_name="MyApp", app_id="MyApp").main_loop()'(as mentioned in #2818). This error now no longer occurs. The output now looks like this:PR Checklist: