Fix Stream closed exception in Rider plugin #1763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The onExit handler was attempting to read from the error stream after the process had exited, but the stream is automatically closed when the process terminates. This caused java.io.IOException: Stream closed. Now read stderr continuously in a background thread during process lifetime and reference the captured output in the onExit handler. This follows the pattern used in JetBrains' own code (ForkedByModuleSplitter) for handling process streams safely.
belav
approved these changes
Dec 5, 2025
Owner
belav
left a comment
belav
left a comment
There was a problem hiding this comment.
LGTM! I'll get a release out with this change shortly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
java.io.IOException: Stream closedexception that occurs when the CSharpier process fails to start in the Rider plugin.Problem
The
onExithandler was attempting to read from the error stream after the process had exited, but streams are automatically closed when a process terminates.Solution
Read stderr continuously in a background thread during the process lifetime and capture output to a
StringBuilder. TheonExithandler then references the captured output instead of trying to read from the closed stream.Approach
This follows the pattern used in JetBrains' own code (
ForkedByModuleSplitter) for handling process streams safely, which uses separate named threads to read stdout and stderr while the process is running.