PR for Issues #7 #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raccon123 |
|
|
beliaev-maksim
requested changes
Jan 12, 2022
README.md
Outdated
| ### Get variable | ||
| Get value of variable _my_var_ | ||
| Get value of variable _my_var_ | ||
| Note Throws error KeyError when Enviroment variable is not found |
There was a problem hiding this comment.
Suggested change
| Note Throws error KeyError when Enviroment variable is not found | |
| > Note: Throws error `KeyError` when Environment variable is not found | |
| > |
| return "" | ||
| if not suppress_echo: | ||
| click.echo("Environment Variable '{}' does not exist".format(name)) | ||
| raise KeyError |
There was a problem hiding this comment.
I have some concerns how this will work in CLI implementation. It will be a long unreadable traceback.
I think we need to raise a KeyError for Python module and just return empty and error message in CLI
There was a problem hiding this comment.
also unittests fail with current implementation. Need to fix it as well
|
No need to run unit test on This might work got unittest working on my machine. |
|
@raccon123 , @TimothyRou |
tests/test_setenv.py
Outdated
Comment on lines
46
to
47
|
|
||
| # |
tests/test_setenv.py
Outdated
| def run_checks(self, user): | ||
| # check that variable does not exist before start | ||
| user_list = ["--user"] if user else [] | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.