Added function to read phone numbers from files #34
+32
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GalenReich
requested changes
May 29, 2024
Contributor
GalenReich
left a comment
GalenReich
left a comment
There was a problem hiding this comment.
Currently, this PR replaces the --phone-numbers CLI argument (for comma-separated phone numbers). We would welcome a PR that added an alternative pathway for providing phone-numbers from a file (perhaps with a new command line argument --file) but providing phone numbers from the command line should be preserved.
Ideally, the new approach to rate limiting would be split into a separate PR as there will likely be several possible approaches, and it would be great to consider these separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.