This repository was archived by the owner on Jan 18, 2018. It is now read-only.
Conversation
qfox
suggested changes
Mar 9, 2017
Contributor
qfox
left a comment
qfox
left a comment
There was a problem hiding this comment.
А зачем все эти изменения в тестах?
| } | ||
|
|
||
| return new BemCell({ entity: new BemEntityName(entity), tech }); | ||
| if (!BemEntityName.isBemEntityName(entity)) { |
Contributor
There was a problem hiding this comment.
I guess we can replace this part of code with BemCell.create({ entity, tech })
|
|
||
| const indexBlock = findIndex(decl, { entity: { block: 'block' } }); | ||
| const indexModifier = findIndex(decl, { entity: { block: 'block', modName: 'mod' } }); | ||
| const indexModifier = findIndex(decl, { entity: { block: 'block', mod: 'mod' } }); |
Contributor
There was a problem hiding this comment.
How new version of bem/naming affects this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved #15