Skip to content

Conversation

@ednolan
Copy link
Member

@ednolan ednolan commented Sep 14, 2025

This commit applies the following changes:

  • Add bemanproject/infra as a beman-submodule in infra/
  • Remove cmake/ (replaced by infra/cmake/)
  • Update the ci_tests.yml file to use the new reusable GitHub Actions workflows
  • Copy over the latest verions of the following paths from exemplar:
    • .devcontainer
    • .gitattributes
    • .github
    • CMakePresets.json
    • LICENSE
  • Add lockfile.json for gtest and google benchmark dependencies
  • README updates:
    • Add a badge for code coverage
    • Add a badge for godbolt
    • Add a LICENSE section
    • Copy CMake verbiage from exemplar
  • CMake updates:
    • Add a 1.0.0 version number
    • Replace install commands with beman_install_library function from infra
    • Replace unconditional FetchContent for test dependencies with find_package commands; users can get FetchContent behavior back with -DCMAKE_PROJECT_TOP_LEVEL_INCLUDES=./infra/cmake/use-fetch-content.cmake

This commit applies the following changes:

- Add bemanproject/infra as a beman-submodule in infra/
- Remove cmake/ (replaced by infra/cmake/)
- Update the ci_tests.yml file to use the new reusable GitHub Actions workflows
- Copy over the latest verions of the following paths from exemplar:
  - .devcontainer
  - .gitattributes
  - .github
  - CMakePresets.json
  - LICENSE
- Add lockfile.json for gtest and google benchmark dependencies
- README updates:
  - Add a badge for code coverage
  - Add a badge for godbolt
  - Add a LICENSE section
  - Copy CMake verbiage from exemplar
- CMake updates:
  - Add a 1.0.0 version number
  - Replace install commands with beman_install_library function from infra
  - Replace unconditional FetchContent for test dependencies with find_package commands; users can get FetchContent behavior back with -DCMAKE_PROJECT_TOP_LEVEL_INCLUDES=./infra/cmake/use-fetch-content.cmake
@@ -0,0 +1,31 @@
#!/usr/bin/env python3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to exclude infra/tools/beman-tidy/tests? This is a lot of artifacts that probably shouldn't be duplicated in version control when they only exist to test beman-tidy and are not part of its core functionality.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is prob outside the scope of this PR, but I think we should move this into infra and symlink unless the repo want to customize the issue templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants