Update repository to conform to Beman project standards #133
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,42 +5,75 @@ | |
|
|
||
| cmake_minimum_required(VERSION 3.25...3.31) | ||
|
|
||
| project(beman.execution VERSION 0.0.1 LANGUAGES CXX) | ||
|
|
||
| # Setup C++ feature tests | ||
| include(CheckCXXSourceCompiles) | ||
|
|
||
| # Check for __cpp_explicit_this_parameter | ||
| check_cxx_source_compiles(" | ||
| struct S { | ||
| void f(this S& self) {} | ||
| }; | ||
| int main() { S s; s.f(); } | ||
| " BEMAN_EXECUTION_HAS_EXPLICIT_THIS_PARAMETER) | ||
|
|
||
| # Check for __cpp_lib_unreachable | ||
| check_cxx_source_compiles(" | ||
| #include <utility> | ||
| int main() { std::unreachable(); } | ||
| " BEMAN_EXECUTION_HAS_LIB_UNREACHABLE) | ||
|
|
||
| # Check for __cpp_lib_forward_like | ||
| check_cxx_source_compiles(" | ||
| #include <utility> | ||
| int main() { | ||
| int x = 42; | ||
| auto&& r = std::forward_like<int&>(x); | ||
| return 0; | ||
| } | ||
| " BEMAN_EXECUTION_HAS_LIB_FORWARD_LIKE) | ||
|
|
||
| # Configure the config.hpp file | ||
| configure_file( | ||
| "${CMAKE_CURRENT_SOURCE_DIR}/include/beman/execution/detail/config/config.hpp.in" | ||
| "${CMAKE_CURRENT_BINARY_DIR}/include/beman/execution/detail/config/config.hpp" | ||
| @ONLY | ||
| ) | ||
|
|
||
| if(${CMAKE_SOURCE_DIR} STREQUAL ${CMAKE_BINARY_DIR}) | ||
| message(FATAL_ERROR "In-source builds are not allowed!") | ||
| endif() | ||
|
|
||
| set(TARGET_NAME beman.execution) | ||
| set(TARGET_NAMESPACE beman) | ||
| set(TARGET_SHORT_NAME execution) | ||
| set(TARGET_ALIAS ${TARGET_NAMESPACE}::${TARGET_SHORT_NAME}) | ||
| set(TARGET_PACKAGE_NAME ${TARGET_NAME}Config) | ||
|
There was a problem hiding this comment. I like the -config version better -@bretbrownjr |
||
| set(TARGETS_EXPORT_NAME ${TARGET_NAME}-targets) | ||
|
|
||
| option( | ||
| BEMAN_execution_BUILD_TESTS | ||
| "Enable building tests and test infrastructure. Default: ON. Values: { ON, OFF }." | ||
| ${PROJECT_IS_TOP_LEVEL} | ||
| ) | ||
|
|
||
| option( | ||
| BEMAN_execution_BUILD_EXAMPLES | ||
| "Enable building examples. Default: ON. Values: { ON, OFF }." | ||
| ${PROJECT_IS_TOP_LEVEL} | ||
| ) | ||
|
|
||
| option( | ||
| BEMAN_execution_ENABLE_INSTALL | ||
| "Install the project components. Values: { ON, OFF }." | ||
| ${PROJECT_IS_TOP_LEVEL} | ||
| ) | ||
|
|
||
| include(GNUInstallDirs) | ||
| set(INSTALL_CONFIGDIR ${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME}) | ||
|
|
||
| if(NOT BEMAN_execution_ENABLE_INSTALL OR CMAKE_SKIP_INSTALL_RULES) | ||
| include(FetchContent) | ||
|
|
||
| # Add project_options from https://github.com/aminya/project_options | ||
|
|
@@ -91,17 +124,17 @@ endif() | |
|
|
||
| add_subdirectory(src/beman/execution) | ||
|
|
||
| if(BEMAN_execution_BUILD_TESTS) | ||
| enable_testing() | ||
|
|
||
| add_subdirectory(tests/beman/execution) | ||
| endif() | ||
|
|
||
| if(BEMAN_execution_BUILD_EXAMPLES) | ||
| add_subdirectory(examples) | ||
| endif() | ||
|
|
||
| if(NOT BEMAN_execution_ENABLE_INSTALL OR CMAKE_SKIP_INSTALL_RULES) | ||
| return() | ||
| endif() | ||
|
|
||
|
|
||
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| beman.execution | ||
| Copyright (c) 2025 The Beman Authors | ||
|
|
||
| This product includes software developed by The Beman Authors | ||
| (https://github.com/bemanproject/beman). | ||
|
|
||
| This product is governed by the Apache License 2.0 WITH LLVM-exception. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // include/beman/execution/detail/config/config.hpp -*-C++-*- | ||
|
There was a problem hiding this comment. I don't like config.hpp files. Remove this and everything related to it |
||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| #ifndef INCLUDED_BEMAN_EXECUTION_DETAIL_CONFIG_CONFIG | ||
| #define INCLUDED_BEMAN_EXECUTION_DETAIL_CONFIG_CONFIG | ||
|
|
||
| // This file is generated at CMake configuration time | ||
|
|
||
| // Feature test macros | ||
| #cmakedefine01 BEMAN_EXECUTION_HAS_EXPLICIT_THIS_PARAMETER | ||
| #cmakedefine01 BEMAN_EXECUTION_HAS_LIB_UNREACHABLE | ||
| #cmakedefine01 BEMAN_EXECUTION_HAS_LIB_FORWARD_LIKE | ||
|
|
||
| // ---------------------------------------------------------------------------- | ||
|
|
||
| #endif // INCLUDED_BEMAN_EXECUTION_DETAIL_CONFIG_CONFIG | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bretbrownjr doesn't like this whole section. Remove everything except the first line (the
beman.executionchange is good.