Fix compiler warnings

run-clang-tidy -fix -checks=bugprone-assert-side-effect,hicpp-*

Author: ClausKlein

examples/fibonacci.cpp

@@ -42,7 +42,8 @@ template <int Capacity> inplace_vector<int, Capacity> fibonacci_to(int num) {
  */
 int main() {
   auto fib_seq = fibonacci_to<50>(10);
-  for (auto i = 0u; i < fib_seq.size(); ++i)
+  for (auto i = 0U; i < fib_seq.size(); ++i) {
     std::cout << i << ": " << fib_seq[i] << "\n";
+  }
   std::cout << std::endl;
 }

include/beman/inplace_vector/inplace_vector.hpp

@@ -335,7 +335,7 @@ class inplace_vector : public inplace_vector_base<T, Capacity> {
     for (; first != last; ++first) {
       emplace_back(*first);
     }
-  }; // freestanding-deleted
+  } // freestanding-deleted
 
 #if defined(__cpp_lib_containers_ranges) and defined(__cpp_concepts)
   template <typename R>
@@ -359,7 +359,7 @@ class inplace_vector : public inplace_vector_base<T, Capacity> {
     for (; first != last; ++first) {
       emplace_back(*first);
     }
-  }; // freestanding-deleted
+  } // freestanding-deleted
 #endif
 
   constexpr void assign(size_type n, const T &u) {
@@ -434,7 +434,7 @@ class inplace_vector : public inplace_vector_base<T, Capacity> {
 
   constexpr reverse_iterator rbegin() noexcept {
     return reverse_iterator{this->end()};
-  };
+  }
   constexpr const_reverse_iterator rbegin() const noexcept {
     return const_reverse_iterator{this->end()};
   }
@@ -452,13 +452,13 @@ class inplace_vector : public inplace_vector_base<T, Capacity> {
 
   constexpr const_reverse_iterator crend() const noexcept {
     return const_reverse_iterator{this->begin()};
-  };
+  }
 
   // [containers.sequences.inplace.vector.members] size/capacity
-  constexpr bool empty() const noexcept { return size() == 0; };
-  constexpr size_type size() const noexcept { return this->size_; };
-  static constexpr size_type max_size() noexcept { return Capacity; };
-  static constexpr size_type capacity() noexcept { return Capacity; };
+  constexpr bool empty() const noexcept { return size() == 0; }
+  constexpr size_type size() const noexcept { return this->size_; }
+  static constexpr size_type max_size() noexcept { return Capacity; }
+  static constexpr size_type capacity() noexcept { return Capacity; }
   constexpr void resize(size_type sz) {
     const auto diff = static_cast<std::ptrdiff_t>(sz - this->size());
     if (diff < 0) {
@@ -471,7 +471,7 @@ class inplace_vector : public inplace_vector_base<T, Capacity> {
       base::uninitialized_value_construct(end, end + diff);
     }
     this->change_size(diff);
-  }; // freestanding-deleted
+  } // freestanding-deleted
   constexpr void resize(size_type sz, const T &c) {
     const auto diff = static_cast<std::ptrdiff_t>(sz - this->size());
     if (diff < 0) {
@@ -484,12 +484,12 @@ class inplace_vector : public inplace_vector_base<T, Capacity> {
       std::uninitialized_fill(end, end + diff, c);
     }
     this->change_size(diff);
-  }; // freestanding-deleted
+  } // freestanding-deleted
   static constexpr void reserve(size_type sz) {
     if (Capacity < sz) {
       throw std::bad_alloc();
     }
-  }; // freestanding-deleted
+  } // freestanding-deleted
   static constexpr void shrink_to_fit() noexcept {}
 
   // [containers.sequences.inplace.vector.modifiers], modifiers
@@ -498,20 +498,20 @@ class inplace_vector : public inplace_vector_base<T, Capacity> {
       throw std::bad_alloc();
     }
     return this->unchecked_emplace_back(std::forward<Args>(args)...);
-  }; // freestanding-deleted
+  } // freestanding-deleted
 
   constexpr reference push_back(const T &x) {
     if (this->size() == Capacity) {
       throw std::bad_alloc();
     }
     return this->unchecked_emplace_back(x);
-  }; // freestanding-deleted
+  } // freestanding-deleted
   constexpr reference push_back(T &&x) {
     if (this->size() == Capacity) {
       throw std::bad_alloc();
     }
     return this->unchecked_emplace_back(std::move(x));
-  }; // freestanding-deleted
+  } // freestanding-deleted
 
 #if defined(__cpp_lib_containers_ranges) and defined(__cpp_concepts)
   template <typename R>
@@ -522,7 +522,7 @@ class inplace_vector : public inplace_vector_base<T, Capacity> {
     for (; first != last; ++first) {
       emplace_back(*first);
     }
-  }; // freestanding-deleted
+  } // freestanding-deleted
 #endif
 
   constexpr void pop_back() {
@@ -531,30 +531,30 @@ class inplace_vector : public inplace_vector_base<T, Capacity> {
       std::destroy(end, end + 1);
       this->change_size(-1);
     }
-  };
+  }
 
   template <class... Args> constexpr pointer try_emplace_back(Args &&...args) {
     if (this->size() == Capacity) {
       return nullptr;
     }
     return std::addressof(
         this->unchecked_emplace_back(std::forward<Args>(args)...));
-  };
+  }
   constexpr pointer
   try_push_back(const T &x) noexcept(std::is_nothrow_copy_constructible_v<T>) {
     if (this->size() == Capacity) {
       return nullptr;
     }
     return std::addressof(this->unchecked_emplace_back(x));
-  };
+  }
 
   constexpr pointer
   try_push_back(T &&x) noexcept(std::is_nothrow_move_constructible_v<T>) {
     if (this->size() == Capacity) {
       return nullptr;
     }
     return std::addressof(this->unchecked_emplace_back(std::move(x)));
-  };
+  }
 
   /*
     template <typename R>
@@ -566,7 +566,7 @@ class inplace_vector : public inplace_vector_base<T, Capacity> {
         emplace_back(*first);
       }
       return frist;
-    };
+    }
   */
 
   template <class... Args>
@@ -580,15 +580,15 @@ class inplace_vector : public inplace_vector_base<T, Capacity> {
 #endif
     this->change_size(1);
     return *final;
-  };
+  }
 
   constexpr reference
   unchecked_push_back(const T &x) noexcept(std::is_nothrow_constructible_v<T>) {
     return this->unchecked_emplace_back(x);
-  };
+  }
   constexpr reference unchecked_push_back(T &&x) {
     return this->unchecked_emplace_back(std::move(x));
-  };
+  }
 
   template <class... Args>
   constexpr iterator emplace(const_iterator position, Args &&...args) {
@@ -609,13 +609,13 @@ class inplace_vector : public inplace_vector_base<T, Capacity> {
       *pos = std::move(temp);
     }
     return pos;
-  }; // freestanding-deleted
+  } // freestanding-deleted
   constexpr iterator insert(const_iterator position, const T &x) {
     return emplace(position, x);
-  }; // freestanding-deleted
+  } // freestanding-deleted
   constexpr iterator insert(const_iterator position, T &&x) {
     return emplace(position, std::move(x));
-  }; // freestanding-deleted
+  } // freestanding-deleted
   constexpr iterator insert(const_iterator position, size_type n, const T &x) {
     const iterator pos = position;
     const iterator end = this->end();
@@ -781,7 +781,7 @@ class inplace_vector : public inplace_vector_base<T, Capacity> {
   constexpr friend std::compare_three_way_result<T>
   operator<=>(const inplace_vector &x, const inplace_vector &y) {
     return std::lexicographical_compare(x.begin(), x.end(), y.begin(), y.end());
-  };
+  }
 #endif
 
   constexpr friend void swap(inplace_vector &x, inplace_vector &y) noexcept(

tests/beman/inplace_vector/inplace_vector.test.cpp

@@ -31,7 +31,7 @@ template <typename T> constexpr void test() {
   static_assert(std::is_same<decltype(const_bracket),
                              typename vec::const_reference>::value,
                 "");
-  assert(front = T(1));
+  assert(front == T(1));
 
   auto &&const_front = const_range.front();
   static_assert(
@@ -69,13 +69,15 @@ void test_exceptions() {
     try {
       vec too_small{};
       auto res = too_small.at(5);
+      (void)res;
     } catch (const std::out_of_range &) {
     } catch (...) {
       assert(false);
     }
     try {
       const vec too_small{};
       auto res = too_small.at(5);
+      (void)res;
     } catch (const std::out_of_range &) {
     } catch (...) {
       assert(false);