Skip to content

Conversation

@20162026
Copy link
Collaborator

@20162026 20162026 commented Aug 7, 2025

close #85

namespace changes:
beman::inplace_vector<..> moved to beman::inplace_vector::inplace_vector<..>
beman::details::inplace_vector moved to beman::inplace_vector::details
beman::freestanding::inplace_vector to beman::inplace_vector::freestanding
beman::from_range polyfill moved to beman::inplace_vector::details::from_range
beman::erase moved to beman::inplace_vector::erase

this will couse some minor inconvenience for anyone who is already using the library, but I do believe we should fix the namespace for consistency

also add missing test case for resize with init value #89

@20162026 20162026 marked this pull request as ready for review August 7, 2025 19:46
Copy link
Member

@wusatosi wusatosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@20162026
Copy link
Collaborator Author

20162026 commented Sep 25, 2025

@wusatosi if there are no objections, I will merge this tomorrow

@JeffGarland
Copy link
Member

LGTM. One thing to consider is that godbolt examples might start to fail after this change, but that can be cleaned up after this commit is synced there.

@20162026 20162026 merged commit ec09767 into bemanproject:main Sep 26, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

namespaces are wrong

4 participants