-
Notifications
You must be signed in to change notification settings - Fork 11
Add fibonacci sequence generation as example #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DeveloperPaul123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just some minor comments.
Regarding the examples in general, are we mandating that they build with all the supported C++ standards that inplace_vector supports?
Thanks for the review, we will eventually add more Example of this being done in exemplar: bemanproject/exemplar#56 |
Ok sounds good, thanks for the link. I have missed the last few sync calls so I'm a bit behind. I only asked because it would be nice to use |
Don't forget we are still on C++20/17 for this library :P |
|
Thanks for the review, merging... |
Adds an example that shows generating a fibonacci sequence as a example.
Packed a very partial
sizefix to let the example compile.