Add missing header: cstdlib #56
Conversation
Also changed the build instruction from -DCMAKE_CXX_STANDARD=20 to -DCMAKE_CXX_STANDARD=23. Signed-off-by: Ted Lyngmo <[email protected]>
TedLyngmo
requested review from
DeveloperPaul123,
Hels15,
camio and
wusatosi
as code owners
| ```text | ||
| # Configure build | ||
| $ cmake -S . -B build -DCMAKE_CXX_STANDARD=20 | ||
| $ cmake -S . -B build -DCMAKE_CXX_STANDARD=23 |
There was a problem hiding this comment.
What was the motivation on changing the standard level to 23? I didn't think this implementation required anything in 23 -- except maybe constexpr which probably depends on 26.
There was a problem hiding this comment.
ok - should that be conditional in the implementation? I mean I get that there's a lot of interest in this at constexpr/eval time -- but lets not forget it's useful for earlier c++ at runtime
There was a problem hiding this comment.
No, it will not compile in pre C++23 mode so, C++23 unconditionally.
There was a problem hiding this comment.
Well, I'm sure with enough macro magic that wouldn't be the case. Obviously with degraded functionality. And to be clear, not trying to be difficult but just explore what's reasonable/possible. Anyway, all good please proceed.
There was a problem hiding this comment.
We changed implementation. C++20 support in doc was for the previous implementation, I must have missed this when switching implementation. I will explore this after #55 is done.
|
Thanks! |
wusatosi
left a comment
wusatosi
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
4 participants
Also changed the build instruction from
-DCMAKE_CXX_STANDARD=20to-DCMAKE_CXX_STANDARD=23.