Improved constructor tests #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbab
requested review from
DeveloperPaul123,
Hels15,
camio and
wusatosi
as code owners
wusatosi
reviewed
Jan 30, 2025
| if (std::is_same_v<T, NonTriviallyDefaultConstructible> || | ||
| std::is_same_v<T, NonTrivial>) { | ||
| if constexpr (std::is_scalar_v<T> || std::is_aggregate_v<T> || | ||
| !std::is_trivially_default_constructible_v<T>) { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
There was a problem hiding this comment.
I am not sure if this is actually better than std::is_same_v<T, NonTriviallyDefaultConstructible> || std::is_same_v<T, NonTrivial>, we can do the comparison here not because the underlying is a scalar or an aggregate, it is because we know it has a well defined value-initialization.
wusatosi
reviewed
Jan 30, 2025
Comment on lines
+87
to
+103
| using T = TestFixture::T; | ||
| using InputIterator = TestFixture::InputIterator; | ||
|
|
||
| IV a(InputIterator{0}, InputIterator{IV::max_size() / 2}); | ||
| EXPECT_EQ(a.size(), IV::max_size() / 2); | ||
| if (!a.empty()) { | ||
| EXPECT_EQ(a.back().value, IV::max_size() / 2 - 1); | ||
| for (std::size_t n : {std::size_t(0), IV::max_size() / 2u, IV::max_size()}) { | ||
| // InputIterator | ||
| InputIterator::num_deref = 0u; | ||
| IV a(InputIterator{}, InputIterator{static_cast<int>(n)}); | ||
| EXPECT_EQ(a.size(), n); | ||
| for (int i = 0; i < static_cast<int>(n); ++i) { | ||
| EXPECT_EQ(a[i], T{i}); | ||
| } | ||
| // Only single-pass through input range | ||
| EXPECT_EQ(InputIterator::num_deref, n); | ||
|
|
||
| // RandomAccessIterator | ||
| IV b(a.begin(), a.end()); | ||
| EXPECT_EQ(b, a); |
Member
There was a problem hiding this comment.
This is really helpful, thanks!
DeveloperPaul123
approved these changes
Jan 30, 2025
Member
DeveloperPaul123
left a comment
DeveloperPaul123
left a comment
There was a problem hiding this comment.
Looks good to me! Nice work 👍
Member
|
@jbab this looks like it's been complete for awhile. I'm going to merge it in the next 24 hours unless there's still something to do here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.