Add build option to turn off dynamic size type selection #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wusatosi
requested review from
DeveloperPaul123,
Hels15 and
camio
as code owners
Comment on lines
+211
to
+214
| By default, | ||
| the type of the size variable in the control block is selected to the smallest | ||
| it could be | ||
| (as an upper bound can be established given we know the capacity of the vector). |
Member
There was a problem hiding this comment.
Is there a reason for the way the lines are broken here?
Member
Author
|
I will revisit this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is added because there maybe a performance penalty due to dynamic size storage that we will need to investigate, see #53 .
Todo: