Skip to content

Conversation

@20162026
Copy link
Collaborator

fix #80 and maybe #92 (yet to test CE locally)

@20162026 20162026 requested a review from a team May 29, 2025 22:00
@wusatosi wusatosi requested a review from nickelpro May 29, 2025 23:35
@wusatosi
Copy link
Member

wusatosi commented May 29, 2025

Let me invite our CMake genius. @nickelpro

btw @20162026 I might be inactive for about one to two weeks, I have an interview coming up so I won't have much time to focus on beman. Review might take longer :|

Copy link
Member

@nickelpro nickelpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option() docstrings should get fixed, other comments are stylistic and not blocking.

Approved on the basis that everything is mechanically correct, but please fix docstrings prior to merge.

Copy link
Member

@wusatosi wusatosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge once requested changes by @nickelpro is implemented, I just gave @20162026 write access to this repo.

@wusatosi
Copy link
Member

I don't think there's any way to test if #92 is fixed locally... @neatudarius do you know anything about testing compiler explorer locally

@20162026
Copy link
Collaborator Author

I don't think there's any way to test if #92 is fixed locally... @neatudarius do you know anything about testing compiler explorer locally

It should be testable and reproducible locally (at least compilers are), but in the worst case, I'll just check again after this PR is merged and CE updates deps.

@wusatosi
Copy link
Member

in the worst case, I'll just check again after this PR is merged and CE updates deps.

I am fine with this, setting up compiler explorer maybe a pain.

@20162026 20162026 requested a review from nickelpro May 31, 2025 07:42
Copy link
Member

@nickelpro nickelpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@20162026 20162026 merged commit ec60ea1 into bemanproject:main May 31, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cmake install is broken

3 participants