Skip to content

Conversation

@RaduNichita
Copy link
Contributor

@RaduNichita RaduNichita commented Nov 10, 2024

The PR imports the ci.yml and CMakePresets from optional26 repository:

  • Enable ASAN run with Clang-19 on CI

  • Enable gcc-14

  • Enable gcc-13

  • Enable gcc-12

  • Enable clang-19

  • Enable clang-18

  • Enable clang-17

Partially Fixes #18 and partially fixes #17

diff  ~/work/beman/optional26/.github/workflows/ci.yml ~/work/beman/iterator_interface/.github/workflows/ci.yml 
16,17d15
<           - {name: "Ubuntu Clang 17", os: ubuntu-24.04, toolchain: "clang-17", clang_version: 17, installed_clang_version: 17, cmake_args: "-G \"Ninja Multi-Config\" -DCMAKE_CONFIGURATION_TYPES=\"RelWithDebInfo;Asan\" "}
<           - {name: "Ubuntu Clang 18", os: ubuntu-24.04, toolchain: "clang-18", clang_version: 18, installed_clang_version: 17, cmake_args: "-G \"Ninja Multi-Config\" -DCMAKE_CONFIGURATION_TYPES=\"RelWithDebInfo;Asan\" "}
20,21c18,19
<           - {name: "Ubuntu GCC 12", os: ubuntu-24.04, toolchain: "gcc-12",  cmake_args: "-G \"Ninja Multi-Config\" -DCMAKE_CONFIGURATION_TYPES=\"RelWithDebInfo;Asan\" "}
<           - {name: "Ubuntu GCC 13", os: ubuntu-24.04, toolchain: "gcc-13",  cmake_args: "-G \"Ninja Multi-Config\" -DCMAKE_CONFIGURATION_TYPES=\"RelWithDebInfo;Asan\" "}
---
>           - {name: "Ubuntu Clang 18", os: ubuntu-24.04, toolchain: "clang-18", clang_version: 18, installed_clang_version: 17, cmake_args: "-G \"Ninja Multi-Config\" -DCMAKE_CONFIGURATION_TYPES=\"RelWithDebInfo;Asan\" "}
>           - {name: "Ubuntu Clang 17", os: ubuntu-24.04, toolchain: "clang-17", clang_version: 17, installed_clang_version: 17, cmake_args: "-G \"Ninja Multi-Config\" -DCMAKE_CONFIGURATION_TYPES=\"RelWithDebInfo;Asan\" "}
22a21,23
>           - {name: "Ubuntu GCC 13", os: ubuntu-24.04, toolchain: "gcc-13",  cmake_args: "-G \"Ninja Multi-Config\" -DCMAKE_CONFIGURATION_TYPES=\"RelWithDebInfo;Asan\" "}
>           - {name: "Ubuntu GCC 12", os: ubuntu-24.04, toolchain: "gcc-12",  cmake_args: "-G \"Ninja Multi-Config\" -DCMAKE_CONFIGURATION_TYPES=\"RelWithDebInfo;Asan\" "}
> 
94a96
> 
diff  ~/work/beman/optional26/CMakePresets.json  ~/work/beman/iterator_interface/CMakePresets.json 
41a42,48
>       "name": "gcc-12",
>       "inherits": "common",
>       "displayName": "GCC 12",
>       "description": "Build with GCC 12 compilers",
>       "toolchainFile": "${sourceDir}/etc/gcc-12-toolchain.cmake"
>     },
>     {
84a92,96
>       "name": "gcc-12",
>       "inherits": "common",
>       "configurePreset": "gcc-12"
>     },
>     {
128a141,145
>       "name": "gcc-12",
>       "inherits": "common",
>       "configurePreset": "gcc-12"
>     },
>     {
196a214,230
>       "name": "gcc-12",
>       "steps": [
>         {
>           "type": "configure",
>           "name": "gcc-12"
>         },
>         {
>           "type": "build",
>           "name": "gcc-12"
>         },
>         {
>           "type": "test",
>           "name": "gcc-12"
>         }
>       ]
>     },
>     {
248a283
> 

Copy link
Member

@neatudarius neatudarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Beman and congratulations for your first contribution!

@RaduNichita RaduNichita force-pushed the radun/add-gcc-12-cmake-presets branch from 0d0847f to 0833f67 Compare November 10, 2024 17:51
@RaduNichita RaduNichita force-pushed the radun/add-gcc-12-cmake-presets branch from 0833f67 to b1d3267 Compare November 10, 2024 17:53
@RaduNichita RaduNichita changed the title Update ci.yml and CMakePresets to enable gcc-13 and clang-19 Update ci.yml and CMakePresets to enable gcc-{12, 13} and clang-19 Nov 10, 2024
@@ -1,75 +1,42 @@
name: Test

name: CI Tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm if this is exactly the same config from optional26?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated description

Copy link
Member

@neatudarius neatudarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I also tested all preset combinations on my local Ubuntu.

clang-{17, 18, 19} and gcc-{12, 13, 14} work on local + CI setup.

Thanks again @RaduNichita and welcome to our community! Looking forward for other contributions!

@neatudarius neatudarius merged commit ba55790 into bemanproject:main Nov 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[LOW] Re-enable ASAN run CI/clang-19 [MEDIUM] Enable latest versions of compilers on main

2 participants