Apply the Beman Standard: cmake related rules #21
Conversation
neatudarius
force-pushed
the
apply_beman_standard/cmake_rules
branch
from
051ab21 to
4888aa1
Compare
neatudarius
changed the title
neatudarius
force-pushed
the
apply_beman_standard/cmake_rules
branch
2 times, most recently
from
d655126 to
3a4033c
Compare
neatudarius
force-pushed
the
apply_beman_standard/cmake_rules
branch
from
3a4033c to
6c3c2ae
Compare
| @@ -1,3 +1 @@ | |||
| [submodule "papers/wg21"] | |||
| path = papers/P2988/wg21 | |||
There was a problem hiding this comment.
This paper is not related to iterator_interfaces (https://wg21.link/P2988). Left over from optional26 repo.
The author for iterator_interfaces does the work for paper outside this repo!
| @@ -0,0 +1,85 @@ | |||
| { | |||
There was a problem hiding this comment.
Imported from optional26 repo. Will discuss more when we'll have a standard one from exemplar. For now, it's good enough.
| @@ -0,0 +1,11 @@ | |||
| root = @CMAKE_SOURCE_DIR@ | |||
There was a problem hiding this comment.
Imported from optional26 repo. Will discuss more when we'll have a standard one from exemplar. For now, it's good enough.
Co-authored-by: Radu Nichita <[email protected]>
|
I think the new Cmake formatter is more forgiving about it?
…On Sun, Nov 10, 2024, 17:15 Darius Neațu ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/CMakeLists.txt
<#21 (comment)>
:
> @@ -0,0 +1,26 @@
+# cmake-format: off
It will mess these next 2 lines. Check the first 4 lines (we dont disable
the check fo r the entire file!
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVNZ5RP4LI3RTHEEPPQRC3Z77LHJAVCNFSM6AAAAABRQPYGUSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMRVHA3DMNRQG4>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
The long term approach would be do sync the formatter in exemplar and then revisit this topic in all repos.\ LE I actually tested and it breaks the license line: An empty line or a "# (empty line after comment)" does not help. |
neatudarius
force-pushed
the
apply_beman_standard/cmake_rules
branch
from
cea67d6 to
dc36058
Compare
neatudarius
force-pushed
the
apply_beman_standard/cmake_rules
branch
from
dc36058 to
266beab
Compare
neatudarius
force-pushed
the
apply_beman_standard/cmake_rules
branch
from
266beab to
faae4f8
Compare
|
LGTM now! Thanks @neatudarius ! |
3 participants
Updates:
NOTE: Small suggestions will be applied afterwards. We need this repo configured for next week presentation.