Merge results of LWG review #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use convert-ref-init-val to convert a U to a T& and initialize value with its address.
GCC 15 correctly notes that 0xCAFEBABE is an unsigned int as an auto.
LEWG had several suggestions for wording.
Use conditional operator instead of if else.
- [X] in p7 what is U? There is something missing - [X] it should be invoke_result_t<F> - [X] the definition of U should be consistent - [X] in p4: we shouldn’t use trailing return types here
Now that "contains a value" is defined for reference optionals.
Update code, also
Add delegation for optional(nullopt_t) constructor.
Tref gets lost.
Fix include/beman/optional/optional.hpp:1368: optioanl ==> optional
Pin one side of value_or ternary to prevent ambiguity in conversions.
Style issue.
Should be "models invocable" not "models invocable<>"
1. missing expos italization of val in contained value defn for optional<T&> 2. In iterator begin() since contained value is now a reference, change the iterator referring to to be to *val 3. Add mandates for transform to require that the result of invoking the supplied function to the contained value can create an object.
P2988R12
Pull Request Test Coverage Report for Build 14283564092Details
💛 - Coveralls |
neatudarius
approved these changes
Apr 10, 2025
| // Example from P2988R5: optional reference. | ||
| [[maybe_unused]] Cat* old_cat = std17::api(); | ||
| [[maybe_unused]] beman::optional::optional<Cat&> new_cat = std26::api(); | ||
|
|
||
| return 0; | ||
| } | ||
|
|
||
| struct derived; |
|
Should we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optional header is in sync with the specification of std::optional. Certain test cases have been added for detecting ambiguous conversions that optional should resolve. These ambiguities were introduced when converting from
if elseconstructs to the ternary? :operator, as that has rules for calculating a common type, where if / else does not.Paper is post LWG review and is immutable at P2988R12.