Skip to content

Conversation

@neatudarius
Copy link
Member

@neatudarius neatudarius commented Dec 15, 2025

Follow-up after #113 . Issue #112

New diff check:

dariusn ~/dev/dn/git/Beman/website [issue/112-v2] $ diff -r ./docs/ ../beman/docs
diff -r ./docs/README.md ../beman/docs/README.md
1,4d0
< ---
< sidebar_position: 1
< ---
< 
diff -r ./docs/beman_library_maturity_model.md ../beman/docs/beman_library_maturity_model.md
1,4d0
< ---
< sidebar_position: 2
< ---
< 
diff -r ./docs/beman_standard.md ../beman/docs/beman_standard.md
1,4d0
< ---
< sidebar_position: 3
< ---
< 
diff -r ./docs/code_of_conduct.md ../beman/docs/code_of_conduct.md
1,4d0
< ---
< sidebar_position: 7
< ---
< 
diff -r ./docs/faq.md ../beman/docs/faq.md
1,4d0
< ---
< sidebar_position: 5
< ---
< 
diff -r ./docs/governance.md ../beman/docs/governance.md
1,4d0
< ---
< sidebar_position: 6
< ---
< 
diff -r ./docs/mission.md ../beman/docs/mission.md
1,4d0
< ---
< sidebar_position: 4
< ---
< 
dariusn ~/dev/dn/git/Beman/website [issue/112-v2] $ diff -r ./images ../beman/images  
dariusn ~/dev/dn/git/Beman/website [issue/112-v2] $

as expected!

We can also validated 100% sync with

dariusn ~/dev/dn/git/Beman/website [issue/112-v2] $ python3 scripts/sync-docs.py ../beman
Copying images from ../beman/images to /Users/dariusn/dev/dn/git/Beman/website/images
Copying images from ../beman/images to /Users/dariusn/dev/dn/git/Beman/website/static/images
Copying images from ../beman/docs/images to /Users/dariusn/dev/dn/git/Beman/website/docs/images
Copying images from ../beman/docs/images to /Users/dariusn/dev/dn/git/Beman/website/static/docs/images
Copying ../beman/docs/README.md to /Users/dariusn/dev/dn/git/Beman/website/docs/README.md
Inserting sidebar position 1 into /Users/dariusn/dev/dn/git/Beman/website/docs/README.md
Copying ../beman/docs/beman_library_maturity_model.md to /Users/dariusn/dev/dn/git/Beman/website/docs/beman_library_maturity_model.md
Inserting sidebar position 2 into /Users/dariusn/dev/dn/git/Beman/website/docs/beman_library_maturity_model.md
Copying ../beman/docs/beman_standard.md to /Users/dariusn/dev/dn/git/Beman/website/docs/beman_standard.md
Inserting sidebar position 3 into /Users/dariusn/dev/dn/git/Beman/website/docs/beman_standard.md
Copying ../beman/docs/mission.md to /Users/dariusn/dev/dn/git/Beman/website/docs/mission.md
Inserting sidebar position 4 into /Users/dariusn/dev/dn/git/Beman/website/docs/mission.md
Copying ../beman/docs/faq.md to /Users/dariusn/dev/dn/git/Beman/website/docs/faq.md
Inserting sidebar position 5 into /Users/dariusn/dev/dn/git/Beman/website/docs/faq.md
Copying ../beman/docs/governance.md to /Users/dariusn/dev/dn/git/Beman/website/docs/governance.md
Inserting sidebar position 6 into /Users/dariusn/dev/dn/git/Beman/website/docs/governance.md
Copying ../beman/docs/code_of_conduct.md to /Users/dariusn/dev/dn/git/Beman/website/docs/code_of_conduct.md
Inserting sidebar position 7 into /Users/dariusn/dev/dn/git/Beman/website/docs/code_of_conduct.md
dariusn ~/dev/dn/git/Beman/website [issue/112-v2] $ git status
On branch issue/112-v2
Your branch is up to date with 'origin/issue/112-v2'.

nothing to commit, working tree clean

@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for bemanproject ready!

Name Link
🔨 Latest commit 67dc9a6
🔍 Latest deploy log https://app.netlify.com/projects/bemanproject/deploys/693fd034bf08970008f59820
😎 Deploy Preview https://deploy-preview-116--bemanproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.


1. [Apache License v2.0 with LLVM Exceptions](https://llvm.org/LICENSE.txt)
2. [Boost Software License 1.0](https://www.boost.org/LICENSE_1_0.txt)
3. [The MIT License](https://opensource.org/license/mit)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeffGarland , I think this is the only relevant change.

Rest of the PR is trigger by formatting changes.

CC: @ednolan @inbal2l @JeffGarland @RaduNichita @mguludag

@neatudarius neatudarius marked this pull request as ready for review December 15, 2025 09:12
@neatudarius
Copy link
Member Author

neatudarius commented Dec 15, 2025

@mguludag / @RaduNichita , why is this check failing now? https://github.com/bemanproject/website/actions/runs/20226495044/job/58059054163?pr=116

I don't think I want to run linters of png files. Or MD linter here (in website repo). It should be exactly mirror of files from beman repo (it's OK to enforce some linting there).

L.E. I see it! it's because of #115. @mguludag can we exclude some directories? docs/ , images/, static/ are linted somewhere else and just imported here.
It's OK to have linting in this repo only for file which exist only in this repo (e.g., blog posts, root README etc).

@JeffGarland
Copy link
Member

@mguludag / @RaduNichita , why is this check failing now? https://github.com/

L.E. I see it! it's because of #115. @mguludag can we exclude some directories? docs/ , images/, static/ are linted somewhere else and just imported here. It's OK to have linting in this repo only for file which exist only in this repo (e.g., blog posts, root README etc).

To me any linting checks need to be in Beman repo so that this can just be a copy here. I'd note that we're mostly removing the linting for text otherwise because it's basically 99%+ false positives (aka whitespace that doesn't matter enforcement) instead of actual issues.

@mguludag
Copy link
Member

mguludag commented Dec 15, 2025

@mguludag / @RaduNichita , why is this check failing now? https://github.com/bemanproject/website/actions/runs/20226495044/job/58059054163?pr=116

I don't think I want to run linters of png files. Or MD linter here (in website repo). It should be exactly mirror of files from beman repo (it's OK to enforce some linting there).

L.E. I see it! it's because of #115. @mguludag can we exclude some directories? docs/ , images/, static/ are linted somewhere else and just imported here. It's OK to have linting in this repo only for file which exist only in this repo (e.g., blog posts, root README etc).

there is an option to exclude folders or particular file types: https://docs.trunk.io/code-quality/overview/linters/ignoring-issues-and-files#ignoring-multiple-files

if we need to exclude some folders maybe I'll create a separate PR for this

@neatudarius
Copy link
Member Author

@mguludag / @RaduNichita , why is this check failing now? https://github.com/bemanproject/website/actions/runs/20226495044/job/58059054163?pr=116
I don't think I want to run linters of png files. Or MD linter here (in website repo). It should be exactly mirror of files from beman repo (it's OK to enforce some linting there).
L.E. I see it! it's because of #115. @mguludag can we exclude some directories? docs/ , images/, static/ are linted somewhere else and just imported here. It's OK to have linting in this repo only for file which exist only in this repo (e.g., blog posts, root README etc).

there is an option to exclude folders or particular file types: https://docs.trunk.io/code-quality/overview/linters/ignoring-issues-and-files#ignoring-multiple-files

if we need to exclude some folders maybe I'll create a separate PR for this

We don't need to exclude some file types. I will give you an example for MD files:

@mguludag , please do a PR to exclude some directories: docs/ , images/, static/.

Copy link
Member

@JeffGarland JeffGarland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@neatudarius neatudarius merged commit f2c7c19 into bemanproject:main Dec 24, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants