fix: use standard checkbox for RSVP#50
Merged
Merged
Conversation
✅ Deploy Preview for bs-said-yes ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Updates the RSVP “household” step to use the shared FormCheckbox component instead of a bespoke RSVP-specific checkbox, aligning RSVP inputs with the app’s standard form controls.
Changes:
- Replaced
RsvpCheckboxusage in the RSVP household step withFormCheckbox. - Extended
FormCheckboxto support checkbox-group usage via optionalname/valueprops andstring[]v-model. - Removed the now-unused
RsvpCheckboxcomponent.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/components/form/rsvp/StepHousehold.vue | Switches RSVP attendee selection to FormCheckbox and adjusts placement of the attendance summary message. |
| app/components/form/RsvpCheckbox.vue | Deletes the custom RSVP checkbox component. |
| app/components/form/FormCheckbox.vue | Adds support for checkbox groups (name/value, string[] v-model) while keeping boolean checkbox usage intact. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current checkbox design is unclear on whether it's selected or deselected on the initial RSVP. Switching to regular checkboxes to make it more clear.