feat: allow images in the accordion module#62
Merged
Merged
Conversation
✅ Deploy Preview for bs-said-yes ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ben-basten
force-pushed
the
feat/faq-photo
branch
from
e48f0a9 to
2a3e2eb
Compare
There was a problem hiding this comment.
Pull request overview
Enables embedded Contentful asset rendering (e.g., images) in rich-text fields used by the Accordion module by fetching linked assets in GraphQL and passing them into the rich-text renderer.
Changes:
- Extend the
TitleCopyGraphQL fragment to fetchcopy.links.assets.blockwith theImagefragment. - Add a shared
getEmbeddedAssetsutility to extract and filter embedded asset links. - Update
CenterTextandAccordionmodules to usegetEmbeddedAssetsand passassetsintoRichTextRenderer.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
server/graphql/fragments/title-copy.fragment.ts |
Fetches linked block assets for rich-text embedded entries via ...Image. |
app/utils/helpers.ts |
Introduces getEmbeddedAssets helper for extracting embedded asset links. |
app/components/modules/CenterText.vue |
Refactors embedded-asset extraction to use the shared helper. |
app/components/modules/Accordion.vue |
Passes extracted embedded assets into RichTextRenderer for accordion item copy. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ben-basten
force-pushed
the
feat/faq-photo
branch
from
2a3e2eb to
c562721
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.