Add name and description parsing to rolltables - #1090
Merged
Conversation
Datasworn oracle rows may carry secondary and tertiary text fragments (`text2`, `text3`) alongside the primary `text`. Populate the table result's `name` and `description` from them instead of collapsing everything into a single `text` value. `name` renders as plain text, so when the primary text contains a compendium or oracle-category link, all fragments are combined into the enriched `text` field instead — each wrapped in its own paragraph so they render on separate lines. Also re-import the affected oracle packs from datasworn-community data.
ben
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Datasworn oracle rows may carry secondary and tertiary text fragments (
text2,text3) alongside the primarytext. Populate the table result'snameanddescriptionfrom them instead of collapsing everything into a singletextvalue.namerenders as plain text, so when the primary text contains a compendium or oracle-category link, all fragments are combined into the enrichedtextfield instead — each wrapped in its own paragraph so they render on separate lines.Also re-import the affected oracle packs from datasworn-community data.
Oracles sometimes contain two or even three results. We can use both
Result NameandResult Descriptionfields in v13 and v14 to display the various results. Datasworn puts the results intotext,text2andtext3. One issue is that any hyperlinks must be placed in theResult Descriptionfield. Currently, foundry-ironsworn puts the singletextentry into theResult Descriptionfield.Logic
textis literal text and is the only entry, put it intoResult Description. (current behavior)textis literal text andtext2and/ortext3exist, then puttextintoResult Nameandtext2andtext3intoResult Descriptiontextis a hyperlink, put alltext*entries intoResult DescriptionOracles for Testing