Skip to content

Make refresh interval and graph time context menu options available on the graphs - #53

Merged
benapetr merged 8 commits into
benapetr:masterfrom
phyrophone:context-menu
May 9, 2026
Merged

benapetr merged 8 commits into
benapetr:masterfrom
phyrophone:context-menu

Conversation

@phyrophone

Copy link
Copy Markdown
Contributor

Made the refresh interval and graph time context menu options be available not only from the side panel, but also from clicking on the graphs.

phyrophone added 7 commits May 6, 2026 14:51
- moved some "refresh interval" code to UIHelper.cpp, to deduplicate code.
- called the new UIHelper functions from the graphs, adding the "refresh interval" options to them.
Moved the "graph time" code to UIHelper, making it also available for the graphs
Added PerformanceWidget::Get() to be able to call it's functions from UIHelper.
ported the timer and onProviderUpdated calls that were present in the old performanceWidget code
@benapetr

benapetr commented May 7, 2026

Copy link
Copy Markdown
Owner

I will test this later it's a large change, but I am just wondering why was that static instance of PerformanceWidget s_instance added there? what purpose does it serve?

Comment thread src/performancewidget.h Outdated
{
Q_OBJECT

static PerformanceWidget *s_instance;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for?

@phyrophone phyrophone May 7, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it stores the instance of PerformaceWidget that Get() returns. I added the getter to make uihelper able to call onProviderUpdated(); and applyGraphWindowSeconds();. used here and here and here

@benapetr
benapetr merged commit 0513346 into benapetr:master May 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants