Repository navigation
Make refresh interval and graph time context menu options available on the graphs - #53
Merged
Merged
Conversation
- moved some "refresh interval" code to UIHelper.cpp, to deduplicate code. - called the new UIHelper functions from the graphs, adding the "refresh interval" options to them.
Moved the "graph time" code to UIHelper, making it also available for the graphs Added PerformanceWidget::Get() to be able to call it's functions from UIHelper.
ported the timer and onProviderUpdated calls that were present in the old performanceWidget code
Owner
|
I will test this later it's a large change, but I am just wondering why was that static instance of PerformanceWidget s_instance added there? what purpose does it serve? |
benapetr
reviewed
May 7, 2026
| { | ||
| Q_OBJECT | ||
|
|
||
| static PerformanceWidget *s_instance; |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the
refresh intervalandgraph timecontext menu options be available not only from the side panel, but also from clicking on the graphs.