Open
Conversation
Owner
|
Thanks for this. I'm running out of time to review this today, but I'll come back to it shortly 👍 |
Contributor
Author
|
@benashford friendly ping :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey :)
This is a rebase of #111 without the stuff related to
inner_hitswhich seemed to be stalling the PR.I've also taken minor steps to avoid having a breaking change by removing the old
mappingmethod.Instead I've opted to
deprecatethat method and just implement it in terms of the new method (mappings) so that people can update at their leisure.