Allow store logger to be configured and update some references to slog default logger#1179
Open
hfoxy wants to merge 2 commits intobenbjohnson:mainfrom
Open
Allow store logger to be configured and update some references to slog default logger#1179hfoxy wants to merge 2 commits intobenbjohnson:mainfrom
hfoxy wants to merge 2 commits intobenbjohnson:mainfrom
Conversation
Collaborator
|
Hey! Thanks for this PR. Just a heads up — #1181 was merged and covers all the After a rebase onto |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the usages of
slog.Info|Warn|Error|Debugto use either the currently defined logger onlitestream.DBor a newly defined logger onlitestream.StoreMotivation and Context
Fixes #1178
How Has This Been Tested?
Ran tests and have deployed this commit to a testing environment with ~27 databases constantly being updated.
Types of changes
Checklist
go fmt,go vet)go test ./...)