test(db): stabilize delayed checkpoint - #1498
Open
corylanou wants to merge 1 commit into
Open
Conversation
PR Build Metrics✅ All clear — no issues detected
Binary Size
Dependency ChangesNo dependency changes. govulncheck OutputBuild Info
🤖 Updated on each push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rework the delayed-checkpoint regression test so it controls checkpoint eligibility explicitly and waits for TXID advancement with a bounded condition poll.
The test now verifies the write sync advances replication before enabling a later time-based checkpoint. Production checkpoint behavior is unchanged.
Motivation and Context
The failed CI attempt showed the initial checkpoint's post-processing outliving the test's 100 ms interval. The supposedly immediate write sync therefore performed the checkpoint early (
insert=4), leaving the later sync at the same TXID (delayed=4). The retry passed, confirming the runner-speed dependency.In scope: deterministic checkpoint setup, eligibility control, bounded polling, and diagnostic timeout output.
Out of scope: production checkpoint logic and unrelated concurrent-write test logging.
Fixes #1495
How Has This Been Tested?
The original failure was also reproduced deterministically before the rewrite, yielding
insert=4 delayed=4.Types of changes
Checklist
go fmt,go vet)go test ./...)