-
Notifications
You must be signed in to change notification settings - Fork 9
Hotfix/unmodified workspace protocol #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ndows instead of nothing.
🦋 Changeset detectedLatest commit: 3258bd5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
If I can help here somehow, just let me know. :) |
|
@0xkalle hi! Thanks for the interest, all that is really remaining in this pr is the CI step cause the current release flow is quite broken, which is part of the reason why everything is busted at the moment. I've been getting a workflow setup in this sandbox repo (bengsfort/irsdk-actions-sandbox) but it has unfortunately taken longer than anticipated due to life stuff. The only thing remaining for the CI step is essentially automatic releasing when "release" commits hit main and then moving the entire workflows over into this repo and updating some of the paths/package names. I was planning on just moving what is there over to this repo tonight once I have some time and cutting a manual release, then adding the automatic releases in later, but if you are willing and have time you could feel free to take a look! Otherwise, I am planning on taking care of this tonight so a release can be made. Really sorry for delays/inconvenience. |
|
No worries. I appreciate your work! I think with that you are faster than I am. As soon as you pushed it I'll test and report back. As I am new to this repo I'll dive deeper into it as soon I am have it initially running. |
Thanks so much! I will try to get this ready and then get a release out, and would be great to get any feedback if it is working. So far from my testing it has worked in all of my test projects, but that has always been the case with this library, so even though I have high confidence this PR will fix the major issues people are facing it is difficult to be 100% confident 😄 I am hoping to soon do a full toolchain overhaul on this project as well, and as part of that I will try to substantially improve the documentation which should hopefully help :) |
Fixes the most critical issues around library usage:
workspace:^protocol. (npm install fails for irsdk-node #8)workspace:protocol, for example using the protocol for optional dependencies, whereas pnpm does not have these issues and has a more well-rounded implementation regarding reliable resolution pre-publish.node-gypthe native library has been migrated to useprebuildifyandnode-gyp-buildto ship pre-built binaries. This should resolve build issues as there is no build to be done on most systems.Additionally, adds example/test projects for educational purposes but also to have multiple batteries-included projects to test the library against, making it much easier to debug and make sure that future releases do not break anything.
PR is still in draft, due to the following: