Just use ThriftOptions in work parameters #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #22, we got rid of that annoying
SerializableThriftOptionstype and expressed a wish to further reduce redundant property munging, maybe with AutoValue. Turns out, AutoValue is a poor fit due to the fact that we use ThriftOptions in a mutable wayTurns out, however, that
ThriftOptionsas used today are perfectly usable inWorkParameters, without extra properties or intermediate types! I don't remember anymore why we needed that second type to begin with; maybe it was the java/kotlin-specific options types that weren't properly serializable? Clearly I misdiagnosed the problem back then. Ah well, works now.