Skip to content

[REFACTOR] - Added dead code verification using knip#119

Draft
Marian-Hristov wants to merge 2 commits into
masterfrom
Refactoring/dead-code
Draft

[REFACTOR] - Added dead code verification using knip#119
Marian-Hristov wants to merge 2 commits into
masterfrom
Refactoring/dead-code

Conversation

@Marian-Hristov

Copy link
Copy Markdown
Collaborator

Summary

Addresses the refactoring the dead code aspect of #96

Related Issues

Partially-Closes #96

Changes Made

  • added dead code detection using knip

Testing

  • Manual testing performed (describe briefly)
  • Unit tests added or updated (if applicable)
  • All tests pass locally / in CI

Checklist (Author & Reviewer)

  • Code follows project conventions
  • The change was run locally and works as expected
  • Acceptance criteria met
  • No breaking changes

@codecov

codecov Bot commented Feb 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Strange4

Strange4 commented Mar 3, 2026

Copy link
Copy Markdown
Collaborator

Nice! I didn't know about this tool. Could you please add it to the pipeline stage for linting?

@Marian-Hristov Marian-Hristov force-pushed the Refactoring/dead-code branch 3 times, most recently from 1e59ca2 to de630d9 Compare March 5, 2026 21:30
@Marian-Hristov Marian-Hristov force-pushed the Refactoring/dead-code branch from de630d9 to bb99f25 Compare March 5, 2026 21:34
@sonarqubecloud

sonarqubecloud Bot commented Mar 5, 2026

Copy link
Copy Markdown

@Marian-Hristov

Copy link
Copy Markdown
Collaborator Author

Im having to nip picking with the knip config. I will move this as a draft as there team decisions to be made

@Marian-Hristov Marian-Hristov marked this pull request as draft March 7, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactoring – Code Refactoring and Sonar Compliance

2 participants