Web Version of App#168
Draft
benjaminsunliu wants to merge 66 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a web-specific map implementation using Leaflet/React-Leaflet for the Expo web build, and adjusts building search UX to better support web interactions.
Changes:
- Add Leaflet + React-Leaflet dependencies (plus
@types/leaflet). - Introduce web-only
MapViewerimplementation with a client-only dynamic import wrapper. - Add a web-only
CampusToggleand updateBuildingSelectionto defer blur handling on web.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds Leaflet/React-Leaflet runtime deps and Leaflet typings. |
| package-lock.json | Locks new Leaflet/React-Leaflet dependency tree (including licenses). |
| components/map/map-viewer.web.tsx | Web entrypoint that lazy-loads the Leaflet-based map client module. |
| components/map/map-viewer.web.client.tsx | Full Leaflet-based web map viewer (buildings, selection, routing overlays, location). |
| components/map/campus-toggle.web.tsx | Web-specific campus toggle that animates the web map region. |
| components/map/building-selection.tsx | Web blur-delay workaround so clicking search results works reliably. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A web version of the app is kept on a separate branch to avoid introducing breaking changes.
Many components / modules we use are mobile only and web requires to duplicate many of them or to modify a lot of things, so to be safe, we will not be merging this to master, it will be kept to generate a web version & link for testing purposes.
Latest web version: https://conumaps.expo.app/
All core features are intended to be functional on web, although some bugs may still be present. When differences exist between platforms, the mobile version remains the primary reference for functionality.
Testing
Checklist (Author & Reviewer)